Fix logic for adding -allow-unsupported-compiler to nvcc #7337
Conversation
The previous logic would always add -allow-unsupported-compiler and -D_ALLOW_COMPILER_AND_STL_VERSION_MISMATCH, even when it was not needed. The revised logic only adds the flags if MSVC>=1940 and CUDA<=12.4. The new code also uses CMAKE_CUDA_FLAGS for the define, which makes CMake's try_compile work reliably if a CMake version >=3.29.4 is used.
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
|
@ssheorey could we get this merged? |
|
@ssheorey Anything I can do to get this merged? |
There was a problem hiding this comment.
Thanks @patrikhuber I simplified the update by removing the duplicate flag check. Duplicate flags should be harmless.
Thanks for merging! I personally think the version with the check is better (and only marginally longer), as the version you merged will add those two flags every time CMake configure is run (which can be very often!). However, maybe one argument for your stripped down version is that medium-term everyone is going to be at CUDA above version 12.5, so this will not be needed anymore anyway (and the flags aren't added for anyone already on CUDA > 12.5 anyway). |
2 participants
The previous logic would always add
-allow-unsupported-compilerand-D_ALLOW_COMPILER_AND_STL_VERSION_MISMATCH, even when it was not needed (e.g. when a recent CUDA version is used), and also printing a (confusing) warning which is not applicable in that case.The revised logic only adds the flags if MSVC>=1940 and CUDA<=12.4. For that, we need to use
find_package(CUDAToolkit REQUIRED), like it's also done a few more lines below in theif(BUILD_COMMON_CUDA_ARCHS)code - and then we append toCMAKE_CUDA_FLAGSonly when needed.The new code also uses CMAKE_CUDA_FLAGS for the
_ALLOW_COMPILER_AND_STL_VERSION_MISMATCHdefine, which makes CMake's try_compile (which is used whenenable_language(CUDA)is called) work reliably if a CMake version >=3.29.4 is used. It doesn't work whenadd_compile_definitions(_ALLOW_COMPILER_AND_STL_VERSION_MISMATCH)is used.Type
Motivation and Context
See above.
Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
See above.